Horton

Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-27T05:17:15Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add TAP test for GUC settings passed via CONNECTION in logical replication.

  2. Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.

  3. Ensure consistent logical replication of datetime and float8 values.

Attachments

On Thu, Nov 27, 2025 at 11:46 AM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Thu, Nov 27, 2025 at 2:37 AM Kirill Reshke <reshkekirill@gmail.com> wrote:
> > Looking at v3 raises two questions for me.
> >
> > First is if we should have a doc notion of which variables ought to be
> > set to what.
>
> Are you suggesting that we document which GUC parameters should be set,
> and to what values, for logical replication? We already have a section on this
> in logical-replication.sgml. Is that sufficient?
>
>
> > Second, how do we actually test that subscription connection options
> > are applied on the subscriber side? Can we have TAP for this  (is is
> > worth the troubles)?
>
> +1 on adding a test. One idea is to enable log_replication_commands via
> the CONNECTION option and then check that the publisher’s log contains
> the message "received replication command: IDENTIFY_SYSTEM".
> There may be a cleaner way to test this, though.

I've added the test and attached it as patch v4-0002.

The test enables log_disconnections via the CONNECTION string and then checks
that the publisher's log contains the expected disconnection message after
the logical replication connection is reestablished.

Regards,

-- 
Fujii Masao