Re: Improve checks for GUC recovery_target_xid
Fujii Masao <masao.fujii@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
To: David Steele <david@pgbackrest.org>
Cc: Michael Paquier <michael@paquier.xyz>, Hüseyin Demir <huseyin.d3r@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2026-03-05T12:42:19Z
Lists: pgsql-hackers
On Thu, Mar 5, 2026 at 5:15 PM David Steele <david@pgbackrest.org> wrote: > > On 3/5/26 12:03, Fujii Masao wrote: > > On Thu, Mar 5, 2026 at 1:21 PM David Steele <david@pgbackrest.org> wrote: > >> The prior standby is not running because of the invalid config. I > >> figured it was better to start clean but when I update the > >> recovery_target_timeline tests I was planning to use the same standby > >> for all the new tests. > > > > Alternatively, we can use $node_primary, since ALTER SYSTEM SET with > > invalid recovery_target_timeline or recovery_target_xid does not > > affect the primary. > > Well, as it turns out I was using the primary after all because I copied > your example and forgot to update the host. Seems weird to set these > GUCs on the primary but as long as we get the expected errors I don't > suppose it matters. Thanks for updating the patch! I've pushed the patch. Regards, -- Fujii Masao
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Improve tests for recovery_target_timeline GUC.
- 2007df43332b 19 (unreleased) landed
-
Improve validation of recovery_target_xid GUC values.
- bffd7130e942 19 (unreleased) landed