Re: unite recovery.conf and postgresql.conf

Fujii Masao <masao.fujii@gmail.com>

From: Fujii Masao <masao.fujii@gmail.com>

To: Peter Eisentraut <peter_e@gmx.net>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Simon Riggs <simon@2ndquadrant.com>, Magnus Hagander <magnus@hagander.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2011-09-20T07:10:14Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Restructure error handling in reading of postgresql.conf.
- d56b3afc0376 9.2.0 cited

On Fri, Sep 16, 2011 at 9:25 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> On fre, 2011-09-16 at 11:54 +0900, Fujii Masao wrote:
>> #1
>> Use empty recovery.ready file to enter arhicve recovery. recovery.conf
>> is not read automatically. All recovery parameters are expected to be
>> specified in postgresql.conf. If you must specify them in recovery.conf,
>> you need to add "include 'recovery.conf'" into postgresql.conf. But note
>> that that recovery.conf will not be renamed to recovery.done at the
>> end of recovery. This is what the patch I've posted does. This is
>> simplest approach, but might confuse people who use the tools which
>> depend on recovery.conf.
>
> A small variant to this:  When you are actually doing recovery from a
> backup, having a recovery trigger and a recovery done file is obviously
> quite helpful and necessary for safety.  But when you're setting up a
> replication slave, it adds extra complexity for the user.  The
> approximately goal ought to be to be able to do
>
> pg_basebackup -h master -D there
> postgres -D there --standby-mode=on --primary-conninfo=master
>
> without the need to touch any obscure recovery trigger files.
>
> So perhaps recovery.{trigger,ready} should not be needed if, say,
> standby_mode=on.

Or what about making pg_basebackup automatically create a
recovery trigger file?

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center