Re: Doc: Add note for running ANALYZE after ALTER TABLE ... SET EXPRESSION
Fujii Masao <masao.fujii@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
To: Yugo Nagata <nagata@sraoss.co.jp>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2025-08-04T11:01:34Z
Lists: pgsql-hackers
On Mon, Aug 4, 2025 at 3:14 PM Yugo Nagata <nagata@sraoss.co.jp> wrote: > > Hi, > > The documentation recommends running ANALYZE after the "ALTER TABLE ... SET DATA TYPE" > command since the statistics will become wrong after that. > > That same thing can be applied to "ALTER TABLE ... SET EXPRESSION" commands, > but that is not described in the documentation, so I've attached a patch > to add this statement. +1 + When this form is used, the column's statistics are removed, + so running <link linkend="sql-analyze"><command>ANALYZE</command></link> + on the table afterwards is recommended. ANALYZE is not needed for virtual generated columns, since they don't have statistics in the first place? If so, would it be clearer to explicitly mention that? How about rephrasing it like this? ------------------------------ When this form is used on a stored generated column, its statistics are removed, so running <link linkend="sql-analyze"><command>ANALYZE </command></link> on the table afterwards is recommended. For a virtual generated column, <command>ANALYZE</command> is not necessary because such columns never have statistics. ------------------------------ Regards, -- Fujii Masao
Commits
-
doc: Recommend ANALYZE after ALTER TABLE ... SET EXPRESSION AS.
- 753177604b33 17.6 landed
- 3e65e77f7666 18.0 landed
- 0b6aea03843d 19 (unreleased) landed