Re: file_fdw: Support multi-line HEADER option.

Fujii Masao <masao.fujii@gmail.com>

From: Fujii Masao <masao.fujii@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Shinya Kato <shinya11.kato@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2026-01-20T14:16:08Z
Lists: pgsql-hackers
On Tue, Jan 20, 2026 at 2:54 PM Chao Li <li.evan.chao@gmail.com> wrote:
> I am sorry maybe I didn’t express myself clear. But in v4, this problem is clearer:
>
> 1 - 0001
> ```
>         /*
> -        * Allow 0, 1, "true", "false", "on", "off", a non-negative integer, or
> -        * "match".
> +        * Allow 0, 1, "true", "false", "on", "off", an integer greater than or
> +        * equal to zero, or "match".
>          */
> ```
>
> Here, “0, 1” is a duplicate of “an integer greater than or equal to zero”, so the commend can be simplified as:

Yeah, the latest patch I attached upthread updates this comment and
removes "0, 1" from it.

Regards,

-- 
Fujii Masao



Commits

  1. file_fdw: Support multi-line HEADER option.

  2. Improve the error message in COPY with HEADER option.

  3. Support multi-line headers in COPY FROM command.