Re: PATCH: pg_basebackup (missing exit on error)

Fujii Masao <masao.fujii@gmail.com>

View thread

From: Fujii Masao <masao.fujii@gmail.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Thomas Ogrisegg <tom-nic@patches.fnord.at>, pgsql-hackers@postgresql.org

Date: 2012-03-28T15:12:26Z

Lists: pgsql-hackers

Attachments

missing_exit_on_error_in_pgbasebackup_v2.patch (application/octet-stream) patch v2

On Wed, Mar 28, 2012 at 9:40 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> I think it would make sense to rearrange that so that we don't have
> two tests for ztarfile != NULL; do that test first, and then if it
> fails, do the strcmp after that.

Makes sense.

> Also, if we're going to test the return value of fclose(), shouldn't
> we also be checking the return value of gzclose()?

Yes, we should.

Attached patch does the above two changes.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center