Horton
Menu

Re: recovery.signal not cleaned up when both signal files are present

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: David Steele <david@pgbackrest.org>
Cc: Michael Paquier <michael@paquier.xyz>, Nikolay Samokhvalov <nik@postgres.ai>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-02-13T06:05:45Z
Lists: pgsql-hackers

Attachments

On Fri, Feb 13, 2026 at 9:55 AM David Steele <david@pgbackrest.org> wrote:
>
> On 2/10/26 11:52, Michael Paquier wrote:
> > On Tue, Feb 10, 2026 at 12:26:36PM +0900, Fujii Masao wrote:
> >> +1 to apply this change only to the master branch. Patch attached.
> >
> > It looks like something we should have a test for, at least..
>
> +1 for a test.

Yeah, so I've added the test as suggested. The updated patch is attached.


> > +    /*
> > +     *
> > +     * If both signal files are present, standby signal file takes precedence.
> > +     * If neither is present then we won't enter archive recovery.
> > +     */
> >
> > This comment's format is incorrect.
>
> Other than the comment the patch looks good overall.

Fixed. Thanks all for the review!

Regards,

-- 
Fujii Masao

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove recovery.signal at recovery end when both signal files are present.