Re: Suggestion to add --continue-client-on-abort option to pgbench

Fujii Masao <masao.fujii@gmail.com>

From: Fujii Masao <masao.fujii@gmail.com>

To: Yugo Nagata <nagata@sraoss.co.jp>

Cc: Chao Li <li.evan.chao@gmail.com>, Rintaro Ikeda <ikedarintarof@oss.nttdata.com>, Jakub Wartak <jakub.wartak@enterprisedb.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, "slpmcf@gmail.com" <slpmcf@gmail.com>, "boekewurm+postgres@gmail.com" <boekewurm+postgres@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Srinath Reddy Sadipiralla <srinath2133@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>

Date: 2025-11-11T15:20:15Z

Lists: pgsql-hackers

On Tue, Nov 11, 2025 at 10:50 AM Yugo Nagata <nagata@sraoss.co.jp> wrote:
> I've attached a patch to fix this.

Thanks for reporting the issue and providing the patch!

> If a PGRES_PIPELINE_SYNC is followed by something other than PGRES_PIPELINE_SYNC or NULL,
> it means that another PGRES_PIPELINE_SYNC will eventually follow after some other results.
> In this case, we should reset the receive_sync flag and continue discarding results.

Yes.

+ if (res)
+ {
+ received_sync = false;
+ continue;

Shouldn't we also call PQclear(res) here? For example:

---------------------------
                if (PQresultStatus(res) == PGRES_PIPELINE_SYNC)
                        received_sync = true;
-               else if (received_sync)
+               else if (received_sync && res == NULL)
                {
-                       /*
-                        * PGRES_PIPELINE_SYNC must be followed by another
-                        * PGRES_PIPELINE_SYNC or NULL; otherwise,
assert failure.
-                        */
-                       Assert(res == NULL);
-
                        /*
                         * Reset ongoing sync count to 0 since all
PGRES_PIPELINE_SYNC
                         * results have been discarded.
@@ -3601,6 +3595,8 @@ discardUntilSync(CState *st)
                        PQclear(res);
                        break;
                }
+               else
+                       received_sync = false;
                PQclear(res);
---------------------------

Regards,

-- 
Fujii Masao

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pgbench: Fix assertion failure with multiple \syncpipeline in pipeline mode.
- 5bc251b28839 17.8 landed
- 00e64e35c8bd 18.2 landed
- 4aa0ac05765e 19 (unreleased) landed
pgbench: Add --continue-on-error option.
- 0ab208fa505c 19 (unreleased) landed
Fix "inconsistent DLL linkage" warning on Windows MSVC
- a3ea5330fcf4 19 (unreleased) cited
pgbench: Fix error reporting in readCommandResponse().
- 7d7e81d1e6b8 13.23 landed
- cb21e1f92fb3 14.20 landed
- bdccb6302871 15.15 landed
- 36c4d30c8f24 16.11 landed
- a912118c6055 17.7 landed
- 29aabbc43269 18.1 landed
- 19d4f9ffc207 19 (unreleased) landed
pgbench: Fix assertion failure with retriable errors in pipeline mode.
- 704f517711b4 15.15 landed
- 8b2e290bde21 16.11 landed
- f39d9164b70a 17.7 landed
- c736808e03b7 18.1 landed
- 8bb174295e89 19 (unreleased) landed
Allow pgbench to retry in some cases.
- 4a39f87acd6e 15.0 cited