Re: Regarding WAL Format Changes

Fujii Masao <masao.fujii@gmail.com>

From: Fujii Masao <masao.fujii@gmail.com>

To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

Cc: Amit Kapila <amit.kapila@huawei.com>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2012-06-27T17:26:38Z

Lists: pgsql-hackers

On Thu, Jun 28, 2012 at 1:13 AM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> On 27.06.2012 18:55, Fujii Masao wrote:
>>
>> On Wed, Jun 27, 2012 at 11:56 PM, Heikki Linnakangas
>> <heikki.linnakangas@enterprisedb.com>  wrote:
>>>
>>> On 27.06.2012 17:14, Amit Kapila wrote:
>>>>
>>>>
>>>> 1. Function header for following functions still contains referece to
>>>> log,
>>>> seg
>>>>    a. InstallXLogFileSegment()
>>>>    b. RemoveOldXlogFiles()
>>>>    c. XLogFileCopy()
>>>>    d. XLogGetLastRemoved()
>>>>    e. UpdateLastRemovedPtr()
>>>>    f. RemoveOldXlogFiles()
>>>
>>>
>>>
>>> Thanks, fixed.
>>
>>
>> There is still reference to log/seg in the comment of
>> InstallXLogFileSegment().
>> The attached patch should be applied?
>
>
> Thanks, applied. Sorry for being so sloppy with this..

No problem. WAL format change you did is really nice!

Regards,

-- 
Fujii Masao