Horton

Re: Unexpected Standby Shutdown on sync_replication_slots change

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Xuneng Zhou <xunengzhou@gmail.com>
Cc: shveta malik <shveta.malik@gmail.com>, Laurenz Albe <laurenz.albe@cybertec.at>, Amit Kapila <amit.kapila16@gmail.com>, Hugo DUBOIS <hdubois@scaleway.com>, pgsql-bugs@lists.postgresql.org
Date: 2025-08-04T11:59:26Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Disallow server start with sync_replication_slots = on and wal_level < logical.

  2. Avoid unexpected shutdown when sync_replication_slots is enabled.

Attachments

On Sat, Aug 2, 2025 at 1:28 PM Xuneng Zhou <xunengzhou@gmail.com> wrote:
> This fix does feel more like an enhancement to user feedback and
> safety nets, not a correction of a broken or unsafe code path. Unable
> to start up with the same settings for it might cause
> more-than-necessary surprise.

Agreed.

At first, since there seems to be rough consensus on applying the current patch
(which prevents unexpected shutdown while the server is running),
I've pushed it to master and back-patched it to v17.

As for the follow-up change that prevents the server from starting with
an invalid configuration, let's continue the discussion. I've attached
the patch and agree it's a good fit for master. However, I'm afraid
it's too late to include it in v18, as beta2 has already been released
and this change is more of an improvement than a bug fix.

Regards,

-- 
Fujii Masao