Horton

Re: pg_restore --no-policies should not restore policies' comment

Fujii Masao <masao.fujii@gmail.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@gmail.com>
To: jian he <jian.universality@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2025-09-09T07:56:15Z
Lists: pgsql-hackers 
On Tue, Sep 9, 2025 at 2:50 PM jian he <jian.universality@gmail.com> wrote:
>
> On Tue, Sep 9, 2025 at 12:00 PM Fujii Masao <masao.fujii@gmail.com> wrote:
> >
> > On Thu, Sep 4, 2025 at 6:00 PM jian he <jian.universality@gmail.com> wrote:
> > > in _tocEntryRestorePass
> > > if we do
> > >
> > >     if ((strcmp(te->desc, "COMMENT") == 0 ||
> > >          strcmp(te->desc, "SECURITY LABEL") == 0) &&
> > >         strncmp(te->tag, "EVENT TRIGGER ", 14) == 0)
> > >         return RESTORE_PASS_POST_ACL;
> > >
> > > then RestorePass related comments also need to be adjusted for security label?
> >
> > Could you clarify which comments should be updated for SECURITY LABEL?
> > I don't see any references to COMMENT in RestorePass, so it doesn't look
> > like any updates are needed there for SECURITY LABEL either. But maybe
> > I'm missing something...
> >
>
> typedef enum
> {
>     RESTORE_PASS_MAIN = 0,        /* Main pass (most TOC item types) */
>     RESTORE_PASS_ACL,            /* ACL item types */
>     RESTORE_PASS_POST_ACL,        /* Event trigger and matview refresh items */
>
> #define RESTORE_PASS_LAST RESTORE_PASS_POST_ACL
> } RestorePass;
>
> I thought we needed to change the comments:
> " /* Event trigger and matview refresh items */".
>
> looking at the code again, we don't need to do that.
> Overall, all the patches look good to me.
> (I didn't test back branch related tests though)

Thanks for the review! Unless there are any objections,
I’ll run the tests again and then push the patches.

Regards,

-- 
Fujii Masao

Commits

  1. pg_dump: Remove unnecessary code for security labels on extensions.

  2. pg_restore: Fix security label handling with --no-publications/subscriptions.

  3. pg_dump: Fix dumping of security labels on subscriptions and event triggers.

  4. pg_restore: Fix comment handling with --no-policies.

  5. pg_restore: Fix comment handling with --no-publications / --no-subscriptions.

  6. Core support for "extensions", which are packages of SQL objects.