Horton

Re: doc: Clarify that empty COMMENT string removes the comment

Fujii Masao <masao.fujii@gmail.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-03-03T00:28:56Z
Lists: pgsql-hackers 
On Tue, Mar 3, 2026 at 8:42 AM Chao Li <li.evan.chao@gmail.com> wrote:
>
>
>
> > On Feb 28, 2026, at 09:21, David G. Johnston <david.g.johnston@gmail.com> wrote:
> >
> > On Fri, Feb 27, 2026 at 5:12 PM Chao Li <li.evan.chao@gmail.com> wrote:
> >
> > PFA v3.

Thanks for updating the patch! LGTM

One more comment: the handling of empty-string comments exists in both
CreateComments() and CreateSharedComments(). For better test coverage,
how about adding also the regression test to check that COMMENT with
empty-string works as expected for shared objects such as roles?

Regards,

-- 
Fujii Masao

Commits

  1. doc: Clarify that empty COMMENT string removes the comment.

  2. Hello.