Re: pg_createsubscriber: Fix incorrect handling of cleanup flags

Fujii Masao <masao.fujii@gmail.com>

From: Fujii Masao <masao.fujii@gmail.com>

To: Nisha Moond <nisha.moond412@gmail.com>

Cc: "David G. Johnston" <david.g.johnston@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2026-05-11T01:22:55Z

Lists: pgsql-hackers

On Sun, May 10, 2026 at 1:30 PM Nisha Moond <nisha.moond412@gmail.com> wrote:
>
> On Wed, Apr 1, 2026 at 1:44 PM Nisha Moond <nisha.moond412@gmail.com> wrote:
> >
> > The patch needed rebasing after recent changes in pg_createsubscriber
> > under commit d6628a5.
> > Please find the rebased patch (v3) attached.
> >
>
> Needed a rebase after recent commits. Attached the rebased v4 patch.

Thanks for updating the patch! It looks good to me.

We can remove the third argument, made_publication, from drop_publication()
since it is no longer used?

Regards,

-- 
Fujii Masao