Horton
Menu

Re: Suggestion to add --continue-client-on-abort option to pgbench

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Yugo Nagata <nagata@sraoss.co.jp>, Rintaro Ikeda <ikedarintarof@oss.nttdata.com>, Jakub Wartak <jakub.wartak@enterprisedb.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, "slpmcf@gmail.com" <slpmcf@gmail.com>, "boekewurm+postgres@gmail.com" <boekewurm+postgres@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Srinath Reddy Sadipiralla <srinath2133@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>
Date: 2025-11-14T09:15:27Z
Lists: pgsql-hackers 
On Fri, Nov 14, 2025 at 4:45 PM Chao Li <li.evan.chao@gmail.com> wrote:
> ```
> +               else if (received_sync && res == NULL)
>                 {
> -                       /*
> -                        * PGRES_PIPELINE_SYNC must be followed by another
> -                        * PGRES_PIPELINE_SYNC or NULL; otherwise, assert failure.
> -                        */
> -                       Assert(res == NULL);
> -
>                         /*
>                          * Reset ongoing sync count to 0 since all PGRES_PIPELINE_SYNC
>                          * results have been discarded.
> @@ -3601,6 +3610,15 @@ discardUntilSync(CState *st)
>                         PQclear(res);
>                         break;
>                 }
> ```
>
> As we now add “res==NULL” to the “else if”, once entering "else if (received_sync && res == NULL)”, res must be NULL, so "PQclear(res);” should be deleted.

OK, the PQclear() there is unnecessary, so I removed it in the patch I
posted earlier.

Regards,

-- 
Fujii Masao

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pgbench: Fix assertion failure with multiple \syncpipeline in pipeline mode.

  2. pgbench: Add --continue-on-error option.

  3. Fix "inconsistent DLL linkage" warning on Windows MSVC

  4. pgbench: Fix error reporting in readCommandResponse().

  5. pgbench: Fix assertion failure with retriable errors in pipeline mode.

  6. Allow pgbench to retry in some cases.