Horton

Re: Online base backup from the hot-standby

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: Steve Singer <ssinger_pg@sympatico.ca>, Jun Ishiduka <ishizuka.jun@po.ntts.co.jp>, magnus@hagander.net, heikki.linnakangas@enterprisedb.com, pgsql-hackers@postgresql.org, robertmhaas@gmail.com, cedric.villemain.debian@gmail.com
Date: 2012-01-26T06:09:33Z
Lists: pgsql-hackers 
On Thu, Jan 26, 2012 at 3:07 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
> On Wed, Jan 25, 2012 at 8:49 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
>> On Wed, Jan 25, 2012 at 8:16 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>>
>>>> What happens if we shutdown the WALwriter and then issue SIGHUP?
>>>
>>> SIGHUP doesn't affect full_page_writes in that case. Oh, you are concerned about
>>> the case where smart shutdown kills walwriter but some backends are
>>> still running?
>>> Currently SIGHUP affects full_page_writes and running backends use the changed
>>> new value of full_page_writes. But in the patch, SIGHUP doesn't affect...
>>>
>>> To address the problem, we should either postpone the shutdown of walwriter
>>> until all backends have gone away, or leave the update of full_page_writes to
>>> checkpointer process instead of walwriter. Thought?
>>
>> checkpointer seems the correct place to me
>
>
> Done.

Thanks a lot!!

I proposed another small patch which fixes the issue about an error message of
pg_basebackup, in this upthread. If it's reasonable, could you commit it?
http://archives.postgresql.org/message-id/CAHGQGwENjSDN=f_VDPwVQ53QRU0cu9+wZKBvwNaEXMawj-y-GQ@mail.gmail.com

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center