Re: Remove unused argument from ApplyLogicalMappingFile()
Fujii Masao <masao.fujii@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: Yugo Nagata <nagata@sraoss.co.jp>,
Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2026-01-28T09:23:47Z
Lists: pgsql-hackers
On Wed, Jan 28, 2026 at 2:18 PM Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com> wrote: > > Dear Nagata-san, > > > I noticed that ApplyLogicalMappingFile() has an unused argument. > > If there is no specific reason for keeping it, I think it could be > > removed. I have attached a small patch that removes this argument. Thanks for the patch! I will commit it. > Good catch. I found that ApplyLogicalMappingFile() has the argument since it was > introduced (b89e151) and was not used from the beginning. Yes. > I removed the argument and ran tests for subscription, they could be passed. Thanks for the test! Regards, -- Fujii Masao
Commits
-
Remove unused argument from ApplyLogicalMappingFile().
- bb26a81ee28c 19 (unreleased) landed