Re: primary_conninfo missing from pg_stat_wal_receiver
Fujii Masao <masao.fujii@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
Stephen Frost <sfrost@snowman.net>, Tom Lane <tgl@sss.pgh.pa.us>, Tatsuo Ishii <ishii@postgresql.org>, Vik Fearing <vik@2ndquadrant.fr>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2016-07-06T10:34:32Z
Lists: pgsql-hackers
On Mon, Jul 4, 2016 at 12:40 PM, Michael Paquier <michael.paquier@gmail.com> wrote: > On Sat, Jul 2, 2016 at 2:56 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote: >> Michael Paquier wrote: >>> On Fri, Jul 1, 2016 at 8:50 AM, Michael Paquier >>> <michael.paquier@gmail.com> wrote: >> >>> >> Okay, that argument I buy. >>> >> >>> >> I suppose this function/view should report no row at all if there is no >>> >> wal receiver connected, rather than a view with nulls. >>> > >>> > The function returns PG_RETURN_NULL() so as we don't have to use a >>> > SRF, and the view checks for IS NOT NULL, so there would be no rows >>> > popping up. >>> >>> In short, I would just go with the attached and call it a day. >> >> Done, thanks. Thanks! I have one question; why do we call the column "conn_info" instead of "conninfo" which is basically used in other places? "conninfo" is better to me. Regards, -- Fujii Masao
Commits
-
Add conninfo to pg_stat_wal_receiver
- 9ed551e0a4fd 9.6.0 landed
-
Only show pg_stat_replication details to superusers
- f88a638199d8 9.1.0 cited