Horton

Re: Online base backup from the hot-standby

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Jun Ishiduka <ishizuka.jun@po.ntts.co.jp>
Cc: ssinger_pg@sympatico.ca, simon@2ndquadrant.com, pgsql-hackers@postgresql.org, magnus@hagander.net, robertmhaas@gmail.com, cedric.villemain.debian@gmail.com, heikki.linnakangas@enterprisedb.com
Date: 2011-10-14T12:28:29Z
Lists: pgsql-hackers 
2011/10/13 Jun Ishiduka <ishizuka.jun@po.ntts.co.jp>:
> I updated to patch corresponded above-comments.

Thanks for updating the patch!

As I suggested in the reply to Simon, I think that the change of FPW
should be WAL-logged separately from that of HS parameters. ISTM
packing them in one WAL record makes XLogReportParameters()
quite confusing. Thought?

 	if (!shutdown && XLogStandbyInfoActive())
+	{
 		LogStandbySnapshot(&checkPoint.oldestActiveXid, &checkPoint.nextXid);
+		XLogReportParameters(REPORT_ON_BACKEND);
+	}

Why doesn't the change of FPW need to be WAL-logged when
shutdown checkpoint is performed? It's helpful to add the comment
explaining why.


Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center