Re: [PATCH] Release replication slot on error in SQL-callable slot functions
Fujii Masao <masao.fujii@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
To: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Cc: shveta malik <shveta.malik@gmail.com>, vignesh C <vignesh21@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
shveta malik <shvetamalik@gmail.com>
Date: 2026-05-29T04:17:17Z
Lists: pgsql-hackers
On Thu, May 28, 2026 at 10:11 AM SATYANARAYANA NARLAPURAM
<satyanarlapuram@gmail.com> wrote:
> Thanks for the patches, I combined these changes in my latest patch. Please find the v5.
Thanks for updating the patch! But, v5 patch caused a compilation failure.
slotfuncs.c:119:32: error: too few arguments to function call, single
argument 'try_disable' was not specified
119 | ReplicationSlotDropAcquired();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
../../../src/include/replication/slot.h:338:13: note:
'ReplicationSlotDropAcquired' declared here
338 | extern void ReplicationSlotDropAcquired(bool try_disable);
| ^ ~~~~~~~~~~~~~~~~
slotfuncs.c:207:32: error: too few arguments to function call, single
argument 'try_disable' was not specified
207 | ReplicationSlotDropAcquired();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
../../../src/include/replication/slot.h:338:13: note:
'ReplicationSlotDropAcquired' declared here
338 | extern void ReplicationSlotDropAcquired(bool try_disable);
| ^ ~~~~~~~~~~~~~~~~
slotfuncs.c:922:32: error: too few arguments to function call, single
argument 'try_disable' was not specified
922 | ReplicationSlotDropAcquired();
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
../../../src/include/replication/slot.h:338:13: note:
'ReplicationSlotDropAcquired' declared here
338 | extern void ReplicationSlotDropAcquired(bool try_disable);
| ^ ~~~~~~~~~~~~~~~~
3 errors generated.
Regards,
--
Fujii Masao