Horton

Re: [bug fix] pg_rewind creates corrupt WAL files, and the standby cannot catch up the primary

Fujii Masao <masao.fujii@gmail.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: "Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2018-03-27T19:45:49Z
Lists: pgsql-hackers 
On Sun, Mar 11, 2018 at 11:04 PM, Michael Paquier <michael@paquier.xyz> wrote:
> On Fri, Mar 09, 2018 at 08:22:49AM +0000, Tsunakawa, Takayuki wrote:
>> Thanks for reviewing.  All done.
>
> Thanks.  Please be careful with the indentation of the patch.  Attached
> is a slightly-updated version with a small modification in
> remove_target_file to make the code cleaner, a proposal of commit
> message and pgindent applied on the code.  I am switching that as ready
> for committer.

The patch looks good to me! Barring objection, I will commit it
and back-patch to 9.5 where pg_rewind was added.

Regards,

-- 
Fujii Masao

Commits

  1. Fix handling of files that source server removes during pg_rewind is running.