Horton

Re: pg_waldump and PREPARE

Fujii Masao <masao.fujii@gmail.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andrey Lepikhov <a.lepikhov@postgrespro.ru>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Thomas Munro <thomas.munro@gmail.com>, Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, vignesh C <vignesh21@gmail.com>
Date: 2019-11-12T08:53:02Z
Lists: pgsql-hackers 
On Mon, Nov 11, 2019 at 4:16 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Mon, Nov 11, 2019 at 01:21:28PM +0900, Fujii Masao wrote:
> > Thanks for the review! You are right.
> > I fixed this issue in the attached patch.
>
> The proposed format looks fine to me.  I have just one comment.  All
> three callers of standby_desc_invalidations() don't actually need to
> print any data if there are zero messages, so you can simplify a bit
> xact_desc_commit() and xact_desc_prepare() regarding the check on
> parsed.nmsgs, no?

Thanks for the review! But probably I failed to understand your point...
Could you clarify what actual change is necessary? You are thinking that
the check of "parsed.nmsgs >= 0" should be moved to the inside of
standby_desc_invalidations()?

Regards,

-- 
Fujii Masao

Commits

  1. Fix comment in xact.h

  2. Make pg_waldump report more detail information about PREPARE TRANSACTION record.

  3. Store 2PC GID in commit/abort WAL recs for logical decoding