Horton

Re: pgbench: make verbose error messages thread-safe

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-05-14T03:34:34Z
Lists: pgsql-hackers 
On Fri, Apr 24, 2026 at 8:23 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Fri, Apr 24, 2026 at 6:06 PM Chao Li <li.evan.chao@gmail.com> wrote:
> > I am not too worried about that, because this code path is only used with --verbose-errors and only when printing error messages. In that situation, the cost of one extra memory allocation per log line should be much smaller than the I/O cost of writing the log message itself. So I think the simpler fix is probably acceptable.
>
> Yes, I feel the same way.

I've pushed the patch. Thanks!

Regards,

-- 
Fujii Masao