Re: Fix memory leak in postmasterMain
Fujii Masao <masao.fujii@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Henrik TJ <henrik@0x48.dk>,
PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2026-04-22T15:29:29Z
Lists: pgsql-hackers
On Wed, Apr 22, 2026 at 3:46 PM Chao Li <li.evan.chao@gmail.com> wrote: > > From my experience, most of the time the postmaster is started with -D. On Linux and macOS, that path can be quite long, PATH_MAX is often 4096 on many Unix-like systems, and I am not sure about Windows. So I think this leak is worth fixing. We can also free()/pfree() userDoption in postgres.c and bootstrap.c? Since userDoption typically uses only a small amount of memory, I'm not sure this patch provides much practical benefit from a memory-leak perspective. So I don't think it needs to be backpatched to the stable branches. OTOH, if it helps keep Valgrind quiet for userDoption, I may be ok with applying it to master. Regards, -- Fujii Masao