Horton
Menu

Re: Log prefix missing for subscriber log messages received from publisher

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, vignesh C <vignesh21@gmail.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-07-22T05:29:51Z
Lists: pgsql-hackers 
On Mon, Jul 21, 2025 at 5:51 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2025-Jul-21, Fujii Masao wrote:
>
> > Thanks for updating the patch! It looks good to me, except for one minor point:
> >
> >  static inline PGresult *libpqsrv_get_result(PGconn *conn, uint32 wait_event_info);
> > +static inline void libpqsrv_notice_receiver(void *arg, const PGresult *res);
> >
> > This prototype is only needed if the function is used earlier in libpq-be-fe-helpers.h,
> > but that's not the case here, so I don't think it's necessary.
> >
> > Unless there are objections, I'll remove that prototype and commit the patch.
>
> LGTM.

I've pushed the patch. Thanks!

Regards,

-- 
Fujii Masao

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove translation marker from libpq-be-fe-helpers.h.

  2. Log remote NOTICE, WARNING, and similar messages using ereport().

  3. Remove translation markers from libpq-be-fe-helpers.h