Horton

Re: [PATCH] Release replication slot on error in SQL-callable slot functions

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: shveta malik <shveta.malik@gmail.com>
Cc: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>, vignesh C <vignesh21@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, shveta malik <shvetamalik@gmail.com>
Date: 2026-05-27T12:10:01Z
Lists: pgsql-hackers 
On Wed, May 27, 2026 at 8:00 PM shveta malik <shveta.malik@gmail.com> wrote:
> pg_copy_physical_replication_slot() should not have it as the common
> 'copy_replication_slot' is already fixed in the patch.

copy_replication_slot() calls create_physical_replication_slot() before
entering the PG_TRY/PG_CATCH block. So if create_physical_replication_slot()
throws an error, wouldn't the same issue still occur?

>  I will review
> the others.

Thanks!

Regards,

-- 
Fujii Masao