Re: incorrect handling of the timeout in pg_receivexlog

Fujii Masao <masao.fujii@gmail.com>

From: Fujii Masao <masao.fujii@gmail.com>

To: Magnus Hagander <magnus@hagander.net>

Cc: Robert Haas <robertmhaas@gmail.com>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2012-06-06T18:10:18Z

Lists: pgsql-hackers

Attachments

timeout_handling_v4.patch (application/octet-stream) patch v4

On Tue, Jun 5, 2012 at 11:42 PM, Magnus Hagander <magnus@hagander.net> wrote:
> Works for me. We still need a (reworked) patch, though, right? We just
> move where the move between seconds and milliseconds happens?

Attached is the updated version of the patch.

> I definitely don't think we need subsecond granularity in the user
> facing number. Even a second is pretty short.

Yep.

> (We do need to retain the ability to set it to 0 = off of course).

Yep, a value of zero disables the status updates, and the patch adds
that explanation into the document of pg_basebackup and pg_receivexlog.

Regards,

-- 
Fujii Masao