Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid

Fujii Masao <masao.fujii@gmail.com>

From: Fujii Masao <masao.fujii@gmail.com>

To: Amul Sul <sulamul@gmail.com>

Cc: vignesh C <vignesh21@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2026-04-16T14:06:25Z

Lists: pgsql-hackers

On Thu, Apr 16, 2026 at 9:31 PM Amul Sul <sulamul@gmail.com> wrote:
> The outer parentheses do not seem to be needed, as
> XLogRecPtrIsInvalid() already includes them.
>
> Other than that, the v3 patch looks good to me.

I've updated the patch based on Amul's suggestion and pushed it. Thanks!

Regards,

-- 
Fujii Masao

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Use XLogRecPtrIsValid() consistently for WAL position checks
- 2fd84e2226e2 19 (unreleased) landed
Use XLogRecPtrIsValid() in various places
- a2b02293bc65 19 (unreleased) cited