Re: Online base backup from the hot-standby

Fujii Masao <masao.fujii@gmail.com>

From: Fujii Masao <masao.fujii@gmail.com>

To: Jun Ishiduka <ishizuka.jun@po.ntts.co.jp>

Cc: pgsql-hackers@postgresql.org, ssinger_pg@sympatico.ca, cedric.villemain.debian@gmail.com, robertmhaas@gmail.com, magnus@hagander.net, heikki.linnakangas@enterprisedb.com

Date: 2011-09-22T13:24:51Z

Lists: pgsql-hackers

Attachments

standby_online_backup_08_fujii.patch (text/x-patch) patch

On Wed, Sep 21, 2011 at 11:50 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> 2011/9/13 Jun Ishiduka <ishizuka.jun@po.ntts.co.jp>:
>>
>> Update patch.
>>
>> Changes:
>>  * set 'on' full_page_writes by user (in document)
>>  * read "FROM: XX" in backup_label (in xlog.c)
>>  * check status when pg_stop_backup is executed (in xlog.c)
>
> Thanks for updating the patch.
>
> Before reviewing the patch, to encourage people to comment and
> review the patch, I explain what this patch provides:

Attached is the updated version of the patch. I refactored the code, fixed
some bugs, added lots of source code comments, improved the document,
but didn't change the basic design. Please check this patch, and let's use
this patch as the base if you agree with that.

In the current patch, there is no safeguard for preventing users from
taking backup during recovery when FPW is disabled. This is unsafe.
Are you planning to implement such a safeguard?

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center