Re: unite recovery.conf and postgresql.conf

Fujii Masao <masao.fujii@gmail.com>

From: Fujii Masao <masao.fujii@gmail.com>

To: Joshua Berkus <josh@agliodbs.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Peter Eisentraut <peter_e@gmx.net>, Simon Riggs <simon@2ndquadrant.com>, Magnus Hagander <magnus@hagander.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2011-09-27T08:33:31Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Restructure error handling in reading of postgresql.conf.
- d56b3afc0376 9.2.0 cited

Attachments

unite_recoveryconf_postgresqlconf_v2.patch (text/x-patch) patch v2

On Tue, Sep 20, 2011 at 3:38 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
>>> What about "recovery.trigger"?
>
> I'm OK with that name.
<snip>
>>> * is there any security hazard from ordinary users being able to see
>>>   what settings had been used?
>>
>> primary_conninfo could be a problem, since it's possible to set a password there.
>
> True. I agree that primary_conninfo should be restricted to superuser.

Though there is still ongonig discussion, since there is no objection about
the above two changes, I revised the patch that way. And I fixed the minor
bug handling the default value of recovery_target_timeline wrongly.
Attached is the revised version of the patch.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center