Horton
Menu

Re: Re: pg_test_timing: fix unit typo and widen diff type

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: "wang.xiao.peng" <wxp_728@163.com>
Cc: Chao Li <li.evan.chao@gmail.com>, lukas@fittl.com, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>, Hannu Krosing <hannuk@google.com>
Date: 2026-04-22T07:04:16Z
Lists: pgsql-hackers 
On Thu, Apr 9, 2026 at 3:13 PM wang.xiao.peng <wxp_728@163.com> wrote:
> Just finished reviewing the v3 patches - looks good to me. The pg_leftmost_one_pos64 fix is spot on, and using INT64_FORMAT for the error message is the right approach.

Since pg_leftmost_one_pos64() can return up to 63, should the size of
histogram[] be changed from 32 to 64? If we want to display the full
histogram[] in the output, max_bit in output() would also need to be set to 63.
Alternatively, it may be fine to keep max_bit = 31 and show only
the first 32 histogram entries.

Patch 0001 looks good to me.

Regards,

-- 
Fujii Masao

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_test_timing: store timing deltas in int64

  2. pg_test_timing: fix unit in backward-clock warning