Horton
Menu

Re: updates for handling optional argument in system functions

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Tristan Partin <tristan@partin.io>
Cc: Mark Wong <markwkm@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2026-07-03T13:59:19Z
Lists: pgsql-hackers 
On Fri, Jun 19, 2026 at 1:50 AM Tristan Partin <tristan@partin.io> wrote:
> > Oops, v8.1 attached to correct that white space.
>
> Patches look great Mark!

Some patches no longer apply cleanly on HEAD, so they'll need to be rebased.

I have one question, though.

Suppose a user executes GRANT or REVOKE on pg_get_ruledef(oid), then
creates a dump with pg_dump. If that dump is restored into a newer
server where these patches have been applied, the restore would fail
because pg_get_ruledef(oid) no longer exists.

Is that acceptable (this means that users need to handle the restore
failure), or should pg_dump handle this case specially?

I suspect we've had similar situations before when system functions
changed between major versions, and I don't recall adding special
handling to pg_dump... Thought?

Regards,

-- 
Fujii Masao

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Simplify creation of built-in functions with default arguments.