Re: Clear base backup progress reporting on error

Fujii Masao <masao.fujii@gmail.com>

From: Fujii Masao <masao.fujii@gmail.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Chao Li <li.evan.chao@gmail.com>, PostgreSQL-development <pgsql-hackers@lists.postgresql.org>
Date: 2026-07-05T23:37:19Z
Lists: pgsql-hackers
On Sat, Jul 4, 2026 at 11:17 PM Andrew Dunstan <andrew@dunslane.net> wrote:
> This has upset the ABI compliance checker (see <https://buildfarm.postgresql.org/cgi-bin/show_failures.pl?max_days=3&stage=abi-compliance-check&filter=Submit> . Looks like you need to update the  .abi-compliance-history file on the affected back branches.

Thanks for pointing out this! That's my mistake...

The ABI break was caused by removing the external function
basebackup_progress_done(). I think the better fix for the stable branches
is to restore that function, even though PostgreSQL core itself no longer
uses it, rather than updating the .abi-compliance-history file. Because
some external backup tools may still be calling basebackup_progress_done().
Thoughts?

Regards,

-- 
Fujii Masao



Commits

  1. Clear base backup progress on backup failure