Horton

Thread

Commits

  1. Fix documentation of pg_start_backup and pg_stop_backup functions.

  1. Minor correction in the doc for non-exclusive pg_start_backup and pg_stop_backup

    Fujii Masao <masao.fujii@gmail.com> — 2019-04-18T15:38:23Z

    Hi,

>     These functions cannot be executed during recovery (except
>     <function>pg_is_in_backup</function>, <function>pg_backup_start_time</function>
>     and <function>pg_wal_lsn_diff</function>).

Regarding backup control functions, the func.sgml describes as above.
But non-exclusive pg_start_backup and pg_stop_backup can also be
executed during recovery, and which should be described in the doc.
So I think that the attached patch should be pushed. Thought?

Probably the patch needs to be back-patched to 9.6 where non-exclusive
backup API was added.

Regards,

-- 
Fujii Masao

  2. Re: Minor correction in the doc for non-exclusive pg_start_backup and pg_stop_backup

    Michael Paquier <michael@paquier.xyz> — 2019-04-19T02:36:54Z

    On Fri, Apr 19, 2019 at 12:38:23AM +0900, Fujii Masao wrote:
> Regarding backup control functions, the func.sgml describes as above.
> But non-exclusive pg_start_backup and pg_stop_backup can also be
> executed during recovery, and which should be described in the doc.
> So I think that the attached patch should be pushed. Thought?
> 
> Probably the patch needs to be back-patched to 9.6 where non-exclusive
> backup API was added.

+1.
--
Michael

  3. Re: Minor correction in the doc for non-exclusive pg_start_backup and pg_stop_backup

    Fujii Masao <masao.fujii@gmail.com> — 2019-04-22T17:46:27Z

    On Fri, Apr 19, 2019 at 11:36 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Apr 19, 2019 at 12:38:23AM +0900, Fujii Masao wrote:
> > Regarding backup control functions, the func.sgml describes as above.
> > But non-exclusive pg_start_backup and pg_stop_backup can also be
> > executed during recovery, and which should be described in the doc.
> > So I think that the attached patch should be pushed. Thought?
> >
> > Probably the patch needs to be back-patched to 9.6 where non-exclusive
> > backup API was added.
>
> +1.

Thanks! Committed.

Regards,


-- 
Fujii Masao