Horton

Re: Your review of pg_receivexlog/pg_basebackup

Fujii Masao <masao.fujii@gmail.com>

View thread
From: Fujii Masao <masao.fujii@gmail.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-10-28T06:46:49Z
Lists: pgsql-hackers 
On Thu, Oct 27, 2011 at 11:14 PM, Magnus Hagander <magnus@hagander.net> wrote:
> Here's a version that does this. Turns out this requires a lot less
> code than what was previously in there, which is always nice.
>
> We still need to solve the other part which is how to deal with the
> partial files on restore. But this is definitely a cleaner way from a
> pure pg_receivexlog perspective.
>
> Comments/reviews?

Looks good.

Minor comment:
the source code comment of FindStreamingStart() seems to need to be updated.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center