Re: unite recovery.conf and postgresql.conf

Fujii Masao <masao.fujii@gmail.com>

From: Fujii Masao <masao.fujii@gmail.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Peter Eisentraut <peter_e@gmx.net>, Simon Riggs <simon@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, Magnus Hagander <magnus@hagander.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2011-09-15T14:32:06Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Restructure error handling in reading of postgresql.conf.
- d56b3afc0376 9.2.0 cited

Attachments

unite_recoveryconf_postgresqlconf_v1.patch (text/x-patch) patch v1

On Thu, Sep 15, 2011 at 8:04 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Thu, Sep 15, 2011 at 5:58 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
>> Alternatively, we could just forget about the whole thing and move
>> everything to postgresql.conf and treat recovery.conf as a simple empty
>> signal file.  I don't know if that's necessarily better.
>
> Seems like it might be simpler.

It seems to need a bit more time until we've reached a consensus about
the treatment of recovery.conf. How about committing the core patch
first, and addressing the recovery.conf issue as a different patch later?

The attached patch provides a core part of the feature, i.e., it moves
every recovery parameters from recovery.conf to postgresql.conf.
Even if you create recovery.conf, the server doesn't read it automatically.

The patch renames recovery.conf to recovery.ready, so if you want to
enter archive recovery or standby mode, you need to create
recovery.ready file in the cluster data directory. Since recovery.ready is
just a signal file, its contents have no effect.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center