Re: pgstattuple "unexpected zero page" for gist and hash indexes
Nitin Motiani <nitinmotiani@google.com>
From: Nitin Motiani <nitinmotiani@google.com>
To: Michael Paquier <michael@paquier.xyz>,
Dilip Kumar <dilipbalaut@gmail.com>, pgsql-hackers@postgresql.org
Date: 2025-10-01T15:01:48Z
Lists: pgsql-hackers
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
pgstattuple: Improve reports generated for indexes (hash, gist, btree)
- c207bf473ee9 13.23 landed
- ee2dbcad02c7 14.20 landed
- 49b5f0b53c63 15.15 landed
- c0f9fe877e23 16.11 landed
- 036decbba2af 17.7 landed
- fc295beb7b74 18.1 landed
- 684a745f5505 19 (unreleased) landed
Attachments
- v3-0001-Fix-unexpected-zero-page-in-pgstattuple-for-hash-.patch (application/octet-stream) patch v3-0001
Apologies, I accidentally sent my previous reply only to Michael instead of hitting 'reply all'. Adding the contents of those messages in the quoted text. On Wed, Oct 1, 2025 at 4:45 PM Michael Paquier <michael@paquier.xyz> wrote: > > On Wed, Oct 01, 2025 at 04:17:49PM +0530, Nitin Motiani wrote: > > Thanks Michael. We can keep the simple change we have in v2 without > > reporting any corruption. But perhaps we should check for the opaque > > size mismatch for btree (as it's already done for gist and hash) to > > keep the code consistent for all three. We can avoid any reporting or > > further analysis but we can skip the other operations in the case of > > size mismatch. What are your thoughts on that? > > You mean an check on BTPageOpaqueData with a new else branch in > pgstat_btree_page()? Yep, let's do that as well. > -- > Michael Thanks Michael. I'm attaching v3 with this change.