Horton

Re: BUG #19367: typos in backend/utils/adt/timestamp.c

Rahila Syed <rahilasyed90@gmail.com>

View thread
From: Rahila Syed <rahilasyed90@gmail.com>
To: fadeymail@rambler.ru, pgsql-bugs@lists.postgresql.org
Date: 2025-12-29T10:25:50Z
Lists: pgsql-bugs 
Hi,

There are typos in return type of these functions:
> 1) timestamptz_pl_interval_at_zone(PG_FUNCTION_ARGS)
>     NOW: PG_RETURN_TIMESTAMP(timestamptz_pl_interval_internal(timestamp,
> span, attimezone));
>     SHOULD:
> PG_RETURN_TIMESTAMPTZ(timestamptz_pl_interval_internal(timestamp, span,
> attimezone));
> 2) Datum timestamptz_mi_interval_at_zone(PG_FUNCTION_ARGS)
>     NOW: PG_RETURN_TIMESTAMP(timestamptz_mi_interval_internal(timestamp,
> span, attimezone));
>     SHOULD:
> PG_RETURN_TIMESTAMPTZ(timestamptz_mi_interval_internal(timestamp, span,
> attimezone));
>
>
You’re right — these are just typos, and they don’t affect correctness
since both
ultimately call Int64GetDatum().
Still, +1 for fixing them for clarity.

Thank you,
Rahila Syed