Horton

Re: Add pg_get_injection_points() for information of injection points

Rahila Syed <rahilasyed90@gmail.com>

View thread View on postgr.es
From: Rahila Syed <rahilasyed90@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Aleksander Alekseev <aleksander@timescale.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>, Kirill Reshke <reshkekirill@gmail.com>
Date: 2025-07-03T06:44:55Z
Lists: pgsql-hackers 
Hi Michael,

 #include "miscadmin.h"
+#include "nodes/execnodes.h"
 #include "nodes/pg_list.h"
 #include "nodes/value.h"

Do we need to include this? I did not see any compilation error when I
removed this.



> Now for the second part with the SRF making the injection point
> information available at SQL level.  The point about adding the new
> function in the core engine has been sticky, and I'm coming down to
> the conclusion that I'd still want to make this stuff backpatchable if
> need be in the future.  So let's just add a new function in the test
> module injection_points and call it a day.
>
>
Do you plan to document this function anywhere where it would be more
visible to those
who might want to use it in their tests?

Thank you,
Rahila Syed

Commits

  1. injection_points: Add injection_points_list()

  2. Add InjectionPointList() to retrieve list of injection points