Re: Subtle bug in "Simplify tape block format" commit

Peter Geoghegan <pg@bowt.ie>

From: Peter Geoghegan <pg@bowt.ie>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-01-30T18:01:12Z
Lists: pgsql-hackers
On Mon, Jan 30, 2017 at 9:55 AM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> It won't make any difference for correctness what bit pattern you write to
> "fill the hole", but you have to write something, and zeros seems like a
> natural choice.

Ah, okay. That's probably fine, then.

Let me take another look at this later today before proceeding. I want
to run it against a custom test suite I've developed.

-- 
Peter Geoghegan


Commits

  1. Don't create "holes" in BufFiles, in the new logtape code.

  2. Simplify tape block format.