Re: Maintaining a list of pgindent commits for "git blame" to ignore
Peter Geoghegan <pg@bowt.ie>
From: Peter Geoghegan <pg@bowt.ie>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bruce Momjian <bruce@momjian.us>,
PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2021-06-21T04:28:15Z
Lists: pgsql-hackers
Attachments
- pgindent-git-blame-ignore-revs (application/octet-stream)
On Thu, Mar 18, 2021 at 4:32 PM Peter Geoghegan <pg@bowt.ie> wrote: > On Thu, Mar 18, 2021 at 4:05 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: > > b5d69b7c22ee4c44b8bb99cfa0466ffaf3b5fab9 # Sun Jun 7 16:57:08 2020 -0400 > > # pgindent run prior to branching v13. > > > > which is easy to make from "git log" or "git show" output. (Because > > of the precedent of those tools, I'd rather write the commit hash > > before the rest of the entry.) > > WFM. What do you think of the attached? I prefer the ISO date style myself, so I went with that. Note that I have included "Modify BufferGetPage() to prepare for "snapshot too old" feature", as well as "Revert no-op changes to BufferGetPage()". I've noticed that those two particular commits cause unhelpful noise when I run "git blame" on access method code. I see problems with these commits often enough to matter. The latter commit cleanly reverted the former after only 12 days, so ignoring both seems okay to me. Everything else should be either pgindent/perltidy related or reformat-dat-files related. -- Peter Geoghegan
Commits
-
Add list of ignorable pgindent commits for git-blame.
- 8e638845ff6b 14.0 landed
-
pgindent run prior to branching v13.
- b5d69b7c22ee 13.0 cited