Horton

Re: SP-GiST confusion: indexed column's type vs. index column type

Peter Geoghegan <pg@bowt.ie>

View thread View on postgr.es
From: Peter Geoghegan <pg@bowt.ie>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Pavel Borisov <pashkin.elfe@gmail.com>
Date: 2021-04-02T16:46:28Z
Lists: pgsql-hackers 
On Fri, Apr 2, 2021 at 9:37 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I propose changing things so that
>
> (A) attType really is the input (heap) data type.
>
> (B) We enforce that leafType agrees with the opclass opckeytype,
> ensuring the index tupdesc can be used for leaf tuples.
>
> (C) The tupdesc passed back for an index-only scan reports the
> input (heap) data type.
>
> This might be too much change for the back branches.  Given the
> lack of complaints to date, I think we can just fix it in HEAD.

+1 to fixing it on HEAD only.

-- 
Peter Geoghegan

Commits

  1. Fix more confusion in SP-GiST.

  2. Fix confusion in SP-GiST between attribute type and leaf storage type.

  3. Rethink handling of pass-by-value leaf datums in SP-GiST.