Re: Uninitialized-variable warnings in nbtinsert.c

Peter Geoghegan <pg@bowt.ie>

From: Peter Geoghegan <pg@bowt.ie>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-06-13T16:29:18Z
Lists: pgsql-hackers
On Sat, Jun 13, 2020 at 9:17 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I scraped the buildfarm's compiler warnings today, as I do from
> time to time, and I noticed that half a dozen animals that normally
> don't report any uninitialized-variable warnings are complaining
> about "curitup" in _bt_doinsert.

(Clearly you meant _bt_check_unique(), not _bt_doinsert().)

> The simplest fix would be to just initialize curitup to NULL in its
> declaration.  But perhaps there's a better way.

Thanks for bringing this to my attention. I'll push a commit that
initializes curitup shortly, targeting both the v13 branch and the
master branch.

-- 
Peter Geoghegan



Commits

  1. Silence _bt_check_unique compiler warning.