pg_waldump/heapdesc.c and struct field names

Peter Geoghegan <pg@bowt.ie>

From: Peter Geoghegan <pg@bowt.ie>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-01-04T03:54:38Z
Lists: pgsql-hackers
I notice that heapdesc.c outputs the field latestRemovedXid as
"remxid". But why? What sense is there in changing the name for output
by tools like pg_waldump, which are intrinsically internals focussed?

Does anyone have any objections to my changing the details within
heapdesc.c on master, so that pg_waldump will use struct field names?
It doesn't seem necessary to change the output that has spaces instead
of an underscore, or something like that. It just seems worth removing
gratuitous inconsistencies, such as this one.

-- 
Peter Geoghegan



Commits

  1. Standardize one aspect of rmgr desc output.