Horton

Re: BUG #17212: pg_amcheck fails on checking temporary relations

Peter Geoghegan <pg@bowt.ie>

View thread View on postgr.es
From: Peter Geoghegan <pg@bowt.ie>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Pavel Borisov <pashkin.elfe@gmail.com>, Alexander Lakhin <exclusion@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-10-11T18:33:40Z
Lists: pgsql-bugs, pgsql-hackers 
On Mon, Oct 11, 2021 at 11:29 AM Mark Dilger
<mark.dilger@enterprisedb.com> wrote:
> The recently submitted patch already contains a short paragraph for each of these, but not a warning box.  Should I reformat those as warning boxes?  I don't know the current thinking on the appropriateness of that documentation style.

I definitely think that it warrants a warning box. This is a huge
practical difference.

Note that I'm talking about a standard thing, which there are
certainly a dozen or more examples of in the docs already. Just grep
for "<warning> </warning>" tags to see the existing warning boxes.

-- 
Peter Geoghegan

Commits

  1. Remove unstable pg_amcheck tests.

  2. pg_amcheck: avoid unhelpful verification attempts.

  3. amcheck: Skip unlogged relations in Hot Standby.

  4. amcheck: Skip unlogged relations during recovery.