Horton

Re: Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages)

Peter Geoghegan <pg@bowt.ie>

View thread View on postgr.es
From: Peter Geoghegan <pg@bowt.ie>
To: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2018-12-18T06:56:56Z
Lists: pgsql-hackers 
On Mon, Dec 17, 2018 at 10:52 PM Andrey Lepikhov
<a.lepikhov@postgrespro.ru> wrote:
> I did many tests of your solution inside the 'quick vacuum' strategy [1]
> and the background worker called 'heap cleaner' [2]. I must admit that
> when I  use your patch, there is no problem with dependencies.

Cool.

> This patch needs opinion of an another reviewer.

Was I unclear on why the patch fixes the problem? Sorry, but I thought
it was obvious.

-- 
Peter Geoghegan

Commits

  1. Redesign the partition dependency mechanism.

  2. Fix trigger drop procedure

  3. Sort the dependent objects before recursing in findDependentObjects().

  4. Avoid sometimes printing both tables and their columns in DROP CASCADE.