Horton

Re: Fixes for two separate bugs in nbtree VACUUM's page deletion

Peter Geoghegan <pg@bowt.ie>

View thread View on postgr.es
From: Peter Geoghegan <pg@bowt.ie>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Teodor Sigaev <teodor@sigaev.ru>, Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2020-04-28T02:35:38Z
Lists: pgsql-hackers 
On Mon, Apr 27, 2020 at 11:02 AM Peter Geoghegan <pg@bowt.ie> wrote:
> I would like to backpatch both patches to all branches that have
> commit 857f9c36cda -- v11, v12, and master. The second issue isn't
> serious, but it seems worth keeping v11+ in sync in this area. Note
> that any backpatch theoretically creates an ABI break for callers of
> the _bt_pagedel() function.

I plan to commit both fixes, while backpatching to v11, v12 and the
master branch on Friday -- barring objections.

I'm almost sure that the ABI thing is a non-issue, but it would be
nice to get that seconded.

-- 
Peter Geoghegan

Commits

  1. Refactor btvacuumpage().

  2. Fix undercounting in VACUUM VERBOSE output.

  3. Fix bug in nbtree VACUUM "skip full scan" feature.

  4. Skip full index scan during cleanup of B-tree indexes when possible