Re: Amcheck verification of GiST and GIN

Peter Geoghegan <pg@bowt.ie>

From: Peter Geoghegan <pg@bowt.ie>

To: Andrey Borodin <amborodin86@gmail.com>

Cc: Jose Arthur Benetasso Villanova <jose.arthur@gmail.com>, Andres Freund <andres@anarazel.de>, Andrey Borodin <x4mmm@yandex-team.ru>, Nikolay Samokhvalov <samokhvalov@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2023-02-04T02:49:50Z

Lists: pgsql-hackers

Attachments

v22-0002-Add-gist_index_parent_check-function-to-verify-G.patch (application/octet-stream) patch v22-0002
v22-0001-Refactor-amcheck-to-extract-common-locking-routi.patch (application/octet-stream) patch v22-0001
v22-0003-Add-gin_index_parent_check-to-verify-GIN-index.patch (application/octet-stream) patch v22-0003

On Thu, Feb 2, 2023 at 12:15 PM Peter Geoghegan <pg@bowt.ie> wrote:
> * Why are there only WARNINGs, never ERRORs here?

Attached revision v22 switches all of the WARNINGs over to ERRORs. It
has also been re-indented, and now uses a non-generic version of
PageGetItemIdCareful() in both verify_gin.c and verify_gist.c.
Obviously this isn't a big set of revisions, but I thought that Andrey
would appreciate it if I posted this much now. I haven't thought much
more about the locking stuff, which is my main concern for now.

Who are the authors of the patch, in full? At some point we'll need to
get the attribution right if this is going to be committed.

I think that it would be good to add some comments explaining the high
level control flow. Is the verification process driven by a
breadth-first search, or a depth-first search, or something else?

I think that we should focus on getting the GiST patch into shape for
commit first, since that seems easier.

-- 
Peter Geoghegan

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

amcheck: Fix posting tree checks in gin_index_check()
- 0cf205e122ae 18.0 landed
amcheck: Fix parent key check in gin_index_check()
- cdd1a431f21d 18.0 landed
amcheck: Fix checks of entry order for GIN indexes
- 0b54b392334b 18.0 landed
amcheck: Remove unused GinScanItem->parentlsn field
- 8dd41c0bff5b 18.0 landed
amcheck: Test gin_index_check on a multicolumn index
- c89d6b889ce9 18.0 landed
Remove incidental md5() function use from test
- 49b82522f13f 18.0 landed
amcheck: Add a GIN index to the CREATE INDEX CONCURRENTLY tests
- 68f97aeadb8e 18.0 landed
amcheck: Add a test with GIN index on JSONB data
- ca738bdc4c9d 18.0 landed
amcheck: Fix indentation in verify_gin.c
- ec4327d106be 18.0 landed
amcheck: Add gin_index_check() to verify GIN index
- 14ffaece0fb5 18.0 landed
amcheck: Move common routines into a separate module
- d70b17636ddf 18.0 landed
Fix grammar in GIN README
- fb9dff76635d 18.0 landed
Avoid amcheck inline compression false positives.
- eba775345d23 12.0 cited