Horton

Re: BUG #17212: pg_amcheck fails on checking temporary relations

Peter Geoghegan <pg@bowt.ie>

View thread View on postgr.es
From: Peter Geoghegan <pg@bowt.ie>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-10-06T06:21:00Z
Lists: pgsql-bugs, pgsql-hackers 
On Tue, Oct 5, 2021 at 11:00 PM Alexander Lakhin <exclusion@gmail.com> wrote:
> I think that ideally pg_amcheck should not fail on a live database, that
> does not contain corrupted data, and should not affect the database
> usage by other users (as it's "only a check").

I agree that that's ideal. As you said, one or two narrow exceptions
may need to be made -- cases where there is unavoidable though weird
ambiguity (and not a report of true corruption). Overall the user
should never see failure from pg_amcheck unless the database is
corrupt, or unless things are defined in a pretty odd way, that
creates ambiguity. Ordinary DDL certainly doesn't count as unusual
here.

-- 
Peter Geoghegan

Commits

  1. Remove unstable pg_amcheck tests.

  2. pg_amcheck: avoid unhelpful verification attempts.

  3. amcheck: Skip unlogged relations in Hot Standby.

  4. amcheck: Skip unlogged relations during recovery.