Re: snapshot too old issues, first around wraparound and then more.
Peter Geoghegan <pg@bowt.ie>
From: Peter Geoghegan <pg@bowt.ie>
To: Noah Misch <noah@leadboat.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Thomas Munro <thomas.munro@gmail.com>, Andres Freund <andres@anarazel.de>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
Kevin Grittner <kgrittn@gmail.com>
Date: 2021-06-16T05:47:45Z
Lists: pgsql-hackers
On Tue, Jun 15, 2021 at 9:59 PM Noah Misch <noah@leadboat.com> wrote: > Hackers are rather wise, but the variety of PostgreSQL use is enormous. We > see that, among other ways, when regression fixes spike in each vN.1. The > $SUBJECT feature was born in response to a user experience; a lack of hacker > interest doesn't invalidate that user experience. I agree that it would be good to hear from some users about this. If a less painful workaround is possible at all, then users may be able to help -- maybe it'll be possible to cut scope. > We face these competing > interests, at least: > 1) Some users want the feature kept so their application can use a certain > pattern of long-running, snapshot-bearing transactions. Undoubtedly true. > 2) (a) Some hackers want the feature gone so they can implement changes > without making those changes cooperate with this feature. (b) Bugs in this > feature make such cooperation materially harder. Is that really true? Though it was probably true back when this thread was started last year, things have changed. Andres found a way to work around the problems he had with snapshot too old, AFAIK. > A hacker adopting the feature would be aiming to reduce (2)(b) to zero, > essentially. What other interests are relevant? The code simply isn't up to snuff. If the code was in a niche contrib module then maybe it would be okay to let this slide. But the fact is that it touches critical parts of the system. This cannot be allowed to drag on forever. It's as simple as that. I admit that I think that the most likely outcome is that it gets reverted. I don't feel great about that. What else can be done about it that will really help the situation? No qualified person is likely to have the time to commit to fixing snapshot too old. Isn't that the real problem here? -- Peter Geoghegan
Commits
-
Remove the "snapshot too old" feature.
- f691f5b80a85 17.0 landed
-
Improve timeout.c's handling of repeated timeout set/cancel.
- 09cf1d522676 14.0 cited
-
Fix two bugs in MaintainOldSnapshotTimeMapping.
- 55b7e2f4d78d 14.0 cited