Thread

Re: s/pg_attribute_always_inline/pg_always_inline/?

Peter Geoghegan <pg@bowt.ie> — 2026-05-27T22:17:20Z

On Thu, Apr 9, 2026 at 10:40 AM Andres Freund <andres@anarazel.de> wrote:
> Created a CF entry, to reduce the chances of me forgetting about committing
> this early in the 20 cycle.

We already have a pg_noinline. How about renaming
pg_attribute_always_inline to pg_mustinline? That is an alternative
that is both consistent with pg_noinline, and even terser than your
proposal.

I have no intention of holding this patch up with bikeshedding. But I
noticed that even your proposed pg_always_inline rename still leaves
function prototypes over the column limit with moderately verbose
function names. It seems better to avoid that outcome.

-- 
Peter Geoghegan